Skip to content

fuse fp32 for GLM-4.5 e_score_correction_bias #22143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2025
Merged

fuse fp32 for GLM-4.5 e_score_correction_bias #22143

merged 1 commit into from
Aug 3, 2025

Conversation

@zRzRzRzRzRzRzR
Copy link
Contributor

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR commented Aug 3, 2025

No description provided.

@zRzRzRzRzRzRzR
fuse fp32
e2b1ab9 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
@github-actions
Copy link

github-actions bot commented Aug 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly forces the e_score_correction_bias parameter to float32 to improve numerical stability in the GLM-4.5 MoE model. My review focuses on improving the code structure by suggesting that this parameter be a direct attribute of the main module rather than being attached to a submodule, which enhances maintainability.

@Isotr0py Isotr0py enabled auto-merge (squash) August 3, 2025 12:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 3, 2025
@vllm-bot vllm-bot merged commit d3c18c9 into vllm-project:main Aug 3, 2025
52 of 55 checks passed
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@zRzRzRzRzRzRzR @npanpaliya
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
9beb290 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
wenbinc-Bin pushed a commit to wenbinc-Bin/vllm-fork that referenced this pull request Aug 7, 2025
@zRzRzRzRzRzRzR @wenbinc-Bin
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
a2f56bb 
Cherry-pick: vllm-project@d3c18c9

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@zRzRzRzRzRzRzR @jinzhen-lin
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
2dad4e6 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
@zRzRzRzRzRzRzR @noamgat
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
2a14e25 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@zRzRzRzRzRzRzR @paulpak58
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
4b5234d 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
wenbinc-Bin pushed a commit to wenbinc-Bin/vllm-fork that referenced this pull request Aug 14, 2025
@zRzRzRzRzRzRzR @wenbinc-Bin
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
154df34 
Cherry-pick: vllm-project@d3c18c9

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@zRzRzRzRzRzRzR @diegocastanibm
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
4d51bdd 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@zRzRzRzRzRzRzR @epwalsh
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
db85cb5 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@zRzRzRzRzRzRzR @zhewenl
fuse fp32 for GLM-4.5 e_score_correction_bias (vllm-project#22143)
fb8c1dd 
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@Isotr0py Isotr0py Isotr0py approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zRzRzRzRzRzRzR @jeejeelee @Isotr0py @vllm-bot